BUG: Index.equals raising with index of tuples that contain NA #48446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Missing-data
jbrockmendel
reviewed
Sep 7, 2022
pandas/_libs/missing.pyx
Outdated
| return False | ||
|
|
||
| for left_element, right_element in zip(left, right): | ||
| if left_element is C_NA and not right_element is C_NA: |
There was a problem hiding this comment.
not right_element is C_NA -> right_element is not C_NA
jbrockmendel
reviewed
Sep 7, 2022
| @@ -659,7 +660,11 @@ def array_equivalent_object(left: object[:], right: object[:]) -> bool: | |||
| and not (isinstance(x, type(y)) or isinstance(y, type(x)))): | |||
| # Check if non-scalars have the same type | |||
| return False | |||
| elif check_na_tuples_nonequal(x, y): | |||
| # We have tuples where one Side has a NA and the other side does not | |||
| return False | |||
There was a problem hiding this comment.
comment that this is the only/main we we expect to get a TypeError
mroeschke
reviewed
Sep 12, 2022
| if not isinstance(left, tuple) or not isinstance(right, tuple): | ||
| return False | ||
|
|
||
| for left_element, right_element in zip(left, right): |
There was a problem hiding this comment.
Should this assert that len(left) == len(right)? Guessing this is assumed upstream but technically (1, NA) and (1,) would return False
There was a problem hiding this comment.
Added. I think we could end up here with weird combinations, so better to be a bit more explicit
# Conflicts: # pandas/_libs/lib.pyx
|
Ok to merge on greenish? |
|
Thanks @phofl |
| @@ -168,7 +168,7 @@ Indexing | |||
|
|
|||
| Missing | |||
| ^^^^^^^ | |||
| - | |||
| - Bug in :meth:`Index.equals` raising ``TypeError` when :class:`Index` consists of tuples that contain ``NA`` (:issue:`48446`) | |||
There was a problem hiding this comment.
looks like this is not rendering correctly due to unbalanced backticks around TypeError.
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…s-dev#48446) * BUG: Index.equals raising with index of tuples that contain NA * Adress review * Add sanity check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This came up when working on MultiIndex.union with ea. Gets converted into a Index of tuples and then raising the error. The added check is a last resort before raising to avoid impacting performance negatively.